Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(footer_sns): turn svg to base64 and save into style.css #319

Merged
merged 3 commits into from
Apr 25, 2017
Merged

feat(footer_sns): turn svg to base64 and save into style.css #319

merged 3 commits into from
Apr 25, 2017

Conversation

neoFelhz
Copy link
Collaborator

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

If you don't do so, we might change your pull request's title and using squash to merge your changed.

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

Turn svg to base64 and save into style.css to reduce the request, for optimize the loading.

Verification steps

Here is a demo: https://fiddle.jshell.net/hjve7jL5/2/

@neoFelhz neoFelhz requested review from cubesky and iblh April 25, 2017 01:49
@neoFelhz neoFelhz merged commit a99d713 into canary Apr 25, 2017
@neoFelhz neoFelhz deleted the feat/footer branch April 25, 2017 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubesky cubesky cubesky approved these changes

@iblh iblh Awaiting requested review from iblh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neoFelhz @cubesky